Added better error message handling in jsregexp
http://codereview.chromium.org/7282026/diff/14007/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/7282026/diff/14007/src/heap.cc#newcode1312 src/heap.cc:1312: On 2011/07/01 09:05:23, Erik Corry wrote:
There is an extra blank line here.
Done. http://codereview.chromium.org/7282026/diff/14007/src/jsregexp.cc File src/jsregexp.cc (right): http://codereview.chromium.org/7282026/diff/14007/src/jsregexp.cc#newcode377 src/jsregexp.cc:377: re->SetDataAt(JSRegExp::saved_code_index(is_ascii), *regexp_err); On 2011/07/01 09:05:23, Erik Corry wrote:
Shouldn't you be setting the kCompilationErrorValue here?
Done. http://codereview.chromium.org/7282026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
