LGTM
http://codereview.chromium.org/7282026/diff/14007/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/7282026/diff/14007/src/heap.cc#newcode1312 src/heap.cc:1312: There is an extra blank line here. http://codereview.chromium.org/7282026/diff/14007/src/jsregexp.cc File src/jsregexp.cc (right): http://codereview.chromium.org/7282026/diff/14007/src/jsregexp.cc#newcode377 src/jsregexp.cc:377: re->SetDataAt(JSRegExp::saved_code_index(is_ascii), *regexp_err); Shouldn't you be setting the kCompilationErrorValue here? http://codereview.chromium.org/7282026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
