Reviewers: Sven,
http://codereview.chromium.org/7343005/diff/1/src/deoptimizer.h File src/deoptimizer.h (right): http://codereview.chromium.org/7343005/diff/1/src/deoptimizer.h#newcode723 src/deoptimizer.h:723: class ScopedDeoptimizedFrameInfo { On 2011/07/12 13:40:32, Sven wrote:
This class looks a bits strange: If the frame passed to the
constructor is not
optimized, every single method call would segfault, meaning that the
constructed
object is illegal from a semantical point of view. Therefore, it
shouldn't be
possible to construct such an instance in the first place. The test
should
probably be moved to the caller or, alternatively, a null object
pattern should
be used.
That is true, but it was the simplest way to have a scoped class that ensured that Deoptimizer::DeleteDebuggerInspectableFrame was called. Let me consider to make it hold the JavaScriptFrame pointer as well. Description: Support scope information and evaluation in optimized frames [email protected] BUG=v8:1140 TEST=test/mjsunit/debug-evaluate-locals-optimized.js,test/mjsunit/debug-evaluate-locals-optimized-double.js Please review this at http://codereview.chromium.org/7343005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/deoptimizer.h M src/mirror-debugger.js M src/runtime.h M src/runtime.cc M test/mjsunit/debug-evaluate-locals-optimized-double.js M test/mjsunit/debug-evaluate-locals-optimized.js -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
