http://codereview.chromium.org/7343005/diff/7001/src/runtime.cc File src/runtime.cc (right):
http://codereview.chromium.org/7343005/diff/7001/src/runtime.cc#newcode10024 src/runtime.cc:10024: void set_frame(JavaScriptFrame* frame) { On 2011/07/13 10:53:46, Sven wrote:
Is it OK (or even intended for correct execution of the code below)
that frame_
and deoptimized_frame_ are "out of sync" after this call? I don't
understand
enough details to decide this. If it *is* OK, perhaps a comment about
this might
be helpful.
Well, this is somewhat odd. The issue is that when inspecting a JavaScript frame (not inlined) it always have the correct number of arguments. If the provided parameters are different the frame below holds the provided arguments. And as a JavaScriptFrameIterator can only expose one JavaScriptFrame it is replaced. I will elaborate the comment and narrow down the usage of this. An even better solution might be to have the FrameInspector control the JavaScriptFrameIterator, but that will be a separate change. http://codereview.chromium.org/7343005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
