LGTM apart from a minor problem understanding the code (see comment)


http://codereview.chromium.org/7343005/diff/7001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7343005/diff/7001/src/runtime.cc#newcode10024
src/runtime.cc:10024: void set_frame(JavaScriptFrame* frame) {
Is it OK (or even intended for correct execution of the code below) that
frame_ and deoptimized_frame_ are "out of sync" after this call? I don't
understand enough details to decide this. If it *is* OK, perhaps a
comment about this might be helpful.

http://codereview.chromium.org/7343005/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to