LGTM except that I'd prefer to avoid the #ifdef---it sets a bad precedent
and
can get ugly.
http://codereview.chromium.org/7544012/diff/1/src/code-stubs.h
File src/code-stubs.h (right):
http://codereview.chromium.org/7544012/diff/1/src/code-stubs.h#newcode959
src/code-stubs.h:959: Handle<Object> value,
I don't really like using the preprocessor like this. Couldn't it be
avoided by passing the root list index always and using the roots array
in the IA32 implementation?
http://codereview.chromium.org/7544012/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
