Seems fine to me. Are you sure you need BitCast?
http://codereview.chromium.org/7544012/diff/7/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7544012/diff/7/src/ia32/code-stubs-ia32.cc#newcode258 src/ia32/code-stubs-ia32.cc:258: // 'null' -> false.!!! Don't be so surprised, it's JavaScript :) http://codereview.chromium.org/7544012/diff/7/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/7544012/diff/7/src/ia32/macro-assembler-ia32.cc#newcode268 src/ia32/macro-assembler-ia32.cc:268: Handle<Object> value(BitCast<Object**>( I don't think we need the BitCast here, the roots array elements are Object*. http://codereview.chromium.org/7544012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
