I'll submit a separate tiny cleanup patch fixing these issues.
http://codereview.chromium.org/7544012/diff/7/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7544012/diff/7/src/ia32/code-stubs-ia32.cc#newcode258 src/ia32/code-stubs-ia32.cc:258: // 'null' -> false.!!! On 2011/08/01 13:02:05, Kevin Millikin wrote:
Don't be so surprised, it's JavaScript :)
Ooops, a leftover from a previous debugging session... :-} http://codereview.chromium.org/7544012/diff/7/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/7544012/diff/7/src/ia32/macro-assembler-ia32.cc#newcode268 src/ia32/macro-assembler-ia32.cc:268: Handle<Object> value(BitCast<Object**>( On 2011/08/01 13:02:05, Kevin Millikin wrote:
I don't think we need the BitCast here, the roots array elements are
Object*. Good point, I should have looked more closely at the actual code when using the time-proven technique of copy-n-paste... :-P http://codereview.chromium.org/7544012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
