Good comments. Please take a new look.
http://codereview.chromium.org/7701023/diff/4001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7701023/diff/4001/src/runtime.cc#newcode695 src/runtime.cc:695: } Should we detect a JSGlobalProxy and return the global object's prototype instead of just the global object? I.e., should the "get prototype" operation be delegated to the global object, just as property accesses? This way, it's visible that there is a JSGlobalProxy, and that it's different from the Global object. http://codereview.chromium.org/7701023/diff/4001/src/v8natives.js File src/v8natives.js (left): http://codereview.chromium.org/7701023/diff/4001/src/v8natives.js#oldcode652 src/v8natives.js:652: return IS_UNDEFINED(desc) ? false : true; Seems not to be called at all, and it was calling %GetPrototype without ensuring that the argument was a JSObject. http://codereview.chromium.org/7701023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
