We can't do access checks on proxies, since our callback only supports a
JSObject as object. We should either 1) not do access checks on proxies,
but
just get the prototype of the proxy, or 2) extend access checks to apply
to
JSReceiver. I'll implement 1 for now, since the ObjectGetPrototypeOf
function
doesn't support proxies at all with the current change.
I think I briefly discussed access checks with Mads some time ago, and the
conclusion was that they are never needed for proxies. So (1) is consistent
with
the proxy code so far.
http://codereview.chromium.org/7701023/diff/4001/src/v8natives.js
File src/v8natives.js (left):
http://codereview.chromium.org/7701023/diff/4001/src/v8natives.js#oldcode652
src/v8natives.js:652: return IS_UNDEFINED(desc) ? false : true;
On 2011/08/24 18:38:40, Mads Ager wrote:
On 2011/08/24 13:39:41, Lasse Reichstein wrote:
> Seems not to be called at all, and it was calling %GetPrototype
without
ensuring
> that the argument was a JSObject.
This looks proxy related. Are you sure that this is not hooked up
somewhere when
running with the proxy flag enabled? You should ask Andreas on this
part of the
code. (You are right about the missing checking that should be added
if this is
not dead code.)
This may very well be dead code. It existed before proxies, I just added
the proxy code path. I already wondered what it was used for...
http://codereview.chromium.org/7701023/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
