LGTM if the proxy code is indeed dead code. Andreas is the code Lasse is deleting here actually dead code?
http://codereview.chromium.org/7701023/diff/4001/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/7701023/diff/4001/src/runtime.cc#newcode695 src/runtime.cc:695: } On 2011/08/24 13:39:41, Lasse Reichstein wrote:
Should we detect a JSGlobalProxy and return the global object's
prototype
instead of just the global object? I.e., should the "get prototype"
operation be
delegated to the global object, just as property accesses? This way, it's visible that there is a JSGlobalProxy, and that it's
different
from the Global object.
I don't remember the exact setup here. There are some hidden prototypes involved in the setup of the global object in the browser, but maybe that is because of the shadow object that is after the proxy but before the actual global. :-) This does not seem to cause trouble and is handled consistently across the __proto__ accessor and this code. I would leave it as is. http://codereview.chromium.org/7701023/diff/4001/src/v8natives.js File src/v8natives.js (left): http://codereview.chromium.org/7701023/diff/4001/src/v8natives.js#oldcode652 src/v8natives.js:652: return IS_UNDEFINED(desc) ? false : true; On 2011/08/24 13:39:41, Lasse Reichstein wrote:
Seems not to be called at all, and it was calling %GetPrototype
without ensuring
that the argument was a JSObject.
This looks proxy related. Are you sure that this is not hooked up somewhere when running with the proxy flag enabled? You should ask Andreas on this part of the code. (You are right about the missing checking that should be added if this is not dead code.) http://codereview.chromium.org/7701023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
