Couple of small suggestions.
http://codereview.chromium.org/7737036/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7737036/diff/1/src/arm/lithium-codegen-arm.cc#newcode1922 src/arm/lithium-codegen-arm.cc:1922: ASSERT(LAST_SPEC_OBJECT_TYPE == LAST_TYPE); This could be a static assert? http://codereview.chromium.org/7737036/diff/1/src/arm/lithium-codegen-arm.cc#newcode1934 src/arm/lithium-codegen-arm.cc:1934: __ cmp(temp2, Operand(FIRST_SPEC_OBJECT_TYPE)); Aren't the flags still set from the previous compare? You could do something like: __ CompareObjectType(...) if (..."Function"...) { __ b(lt, is_false); __ b(eq, is_true); } else { __ b(le, is_false); } ? http://codereview.chromium.org/7737036/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/7737036/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1749 src/ia32/lithium-codegen-ia32.cc:1749: ASSERT(LAST_SPEC_OBJECT_TYPE == LAST_TYPE); STATIC_ASSERT? http://codereview.chromium.org/7737036/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1761 src/ia32/lithium-codegen-ia32.cc:1761: __ CmpInstanceType(temp, FIRST_SPEC_OBJECT_TYPE); Same comment about restructuring this code a bit as on the ARM platform. http://codereview.chromium.org/7737036/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
