LGTM
http://codereview.chromium.org/7737036/diff/3002/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/7737036/diff/3002/src/ia32/lithium-codegen-ia32.cc#newcode1749 src/ia32/lithium-codegen-ia32.cc:1749: // either "Object" or "Function", only the branch conditions differ. The test for Object involves two comparisons and two conditional jumps, but I think the range is contiguous. That means it could be done with a subtract, a compare and an unsigned conditional branch. http://codereview.chromium.org/7737036/diff/3002/src/macros.py File src/macros.py (right): http://codereview.chromium.org/7737036/diff/3002/src/macros.py#newcode119 src/macros.py:119: # This is the same as being either a function or an object in V8 terminology. Is this comment accurate and up to date? I think it covers JSFunction, JSObject and the new proxy types now, right? http://codereview.chromium.org/7737036/diff/3002/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7737036/diff/3002/src/objects-inl.h#newcode527 src/objects-inl.h:527: (HeapObject::cast(this)->map()->instance_type()
= FIRST_JS_PROXY_TYPE &&
This would be neater if you extract the instance type into a variable first. http://codereview.chromium.org/7737036/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
