http://codereview.chromium.org/7737036/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/7737036/diff/1/src/arm/lithium-codegen-arm.cc#newcode1922
src/arm/lithium-codegen-arm.cc:1922: ASSERT(LAST_SPEC_OBJECT_TYPE ==
LAST_TYPE);
On 2011/09/07 10:13:12, Kevin Millikin wrote:
This could be a static assert?
Done.
http://codereview.chromium.org/7737036/diff/1/src/arm/lithium-codegen-arm.cc#newcode1934
src/arm/lithium-codegen-arm.cc:1934: __ cmp(temp2,
Operand(FIRST_SPEC_OBJECT_TYPE));
On 2011/09/07 10:13:12, Kevin Millikin wrote:
Aren't the flags still set from the previous compare? You could do
something
like:
__ CompareObjectType(...)
if (..."Function"...) {
__ b(lt, is_false);
__ b(eq, is_true);
} else {
__ b(le, is_false);
}
?
Of course. That was the whole intent of the ordering I chose, and I
overlooked to take advantage of it here. 8-}
http://codereview.chromium.org/7737036/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.org/7737036/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1749
src/ia32/lithium-codegen-ia32.cc:1749: ASSERT(LAST_SPEC_OBJECT_TYPE ==
LAST_TYPE);
On 2011/09/07 10:13:12, Kevin Millikin wrote:
STATIC_ASSERT?
Done.
http://codereview.chromium.org/7737036/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1761
src/ia32/lithium-codegen-ia32.cc:1761: __ CmpInstanceType(temp,
FIRST_SPEC_OBJECT_TYPE);
On 2011/09/07 10:13:12, Kevin Millikin wrote:
Same comment about restructuring this code a bit as on the ARM
platform.
Done. (And also on x64.)
http://codereview.chromium.org/7737036/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
