Cool, I hadn't thought about having the ESR be a member of v8::Extension
that
way.
http://codereview.chromium.org/7889046/diff/1/include/v8.h
File include/v8.h (right):
http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode1171
include/v8.h:1171: V8EXPORT const
ExternalAsciiStringResource*GetExternalAsciiStringResource()
Nit: Put the space back after the *.
http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode2456
include/v8.h:2456: ExternalAsciiStringResourceImpl(const char *data,
size_t length)
In chrome, the * goes next to the type.
http://codereview.chromium.org/7889046/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/7889046/diff/1/src/api.cc#newcode507
src/api.cc:507: source_length_(source_length >= 0 ?
Nested ternary operators are hard to read and this is a bit long for an
initialization list. how about just doing the strlen() bit in the
constructor body.
http://codereview.chromium.org/7889046/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
