http://codereview.chromium.org/7889046/diff/1/include/v8.h File include/v8.h (right):
http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode2455 include/v8.h:2455: ExternalAsciiStringResourceImpl() : data_(0), length_(0) {}; No ; at the end? http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode2457 include/v8.h:2457: : data_(data), length_(length) {}; ; at the end should not be necessary http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode2460 include/v8.h:2460: private: Newline before private: http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode2476 include/v8.h:2476: int source_length = -1); I wish there was a way to reduce the number of optional paramters in a row. E.g. does the source parameter have to be optional? http://codereview.chromium.org/7889046/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/7889046/diff/1/test/cctest/test-api.cc#newcode4298 test/cctest/test-api.cc:4298: for (int source_len = kEmbeddedExtensionSourceValidLen; Why does this loop go from kEmbeddedExtensionSourceValidLen to kEmbeddedExtensionSourceValidLen? Shouldn't it start from 0? http://codereview.chromium.org/7889046/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
