http://codereview.chromium.org/7889046/diff/1/include/v8.h File include/v8.h (right):
http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode1171 include/v8.h:1171: V8EXPORT const ExternalAsciiStringResource*GetExternalAsciiStringResource() On 2011/09/14 20:33:18, Aaron Boodman wrote:
Nit: Put the space back after the *.
Whoops! Thanks. http://codereview.chromium.org/7889046/diff/1/include/v8.h#newcode2456 include/v8.h:2456: ExternalAsciiStringResourceImpl(const char *data, size_t length) On 2011/09/14 20:33:18, Aaron Boodman wrote:
In chrome, the * goes next to the type.
I'm trying to untrain myself. Fixed; thanks. http://codereview.chromium.org/7889046/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/7889046/diff/1/src/api.cc#newcode507 src/api.cc:507: source_length_(source_length >= 0 ? On 2011/09/14 20:33:18, Aaron Boodman wrote:
Nested ternary operators are hard to read and this is a bit long for
an
initialization list. how about just doing the strlen() bit in the
constructor
body.
You're right; it works great as-is but it's fragile enough to break if you look at it funny. I'll fix it, and in the process return the source_length/source arguments to a more natural order in the declaration. http://codereview.chromium.org/7889046/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
