http://codereview.chromium.org/9148006/diff/1011/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right):
http://codereview.chromium.org/9148006/diff/1011/src/ia32/macro-assembler-ia32.cc#newcode997 src/ia32/macro-assembler-ia32.cc:997: lea(r1, Operand(seed, RelocInfo::NONE)); No reason to use lea here when mov would do. http://codereview.chromium.org/9148006/diff/1011/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/9148006/diff/1011/src/objects-inl.h#newcode2060 src/objects-inl.h:2060: uint32_t entry = FirstProbe(Shape::Hash(key, GetHeap()->StringHashSeed()), isolate->heap() is faster than GetHeap() If the arguments don't all fit on one line they should have a line each. http://codereview.chromium.org/9148006/diff/1011/src/objects-inl.h#newcode4544 src/objects-inl.h:4544: uint32_t NumberDictionaryShape::HashForObject(uint32_t key, uint32_t seed, Formatting. http://codereview.chromium.org/9148006/diff/1011/src/objects-inl.h#newcode4569 src/objects-inl.h:4569: uint32_t StringDictionaryShape::HashForObject(String* key, uint32_t, Formatting. http://codereview.chromium.org/9148006/diff/1011/src/objects.h File src/objects.h (right): http://codereview.chromium.org/9148006/diff/1011/src/objects.h#newcode2760 src/objects.h:2760: static inline uint32_t HashForObject(HashTableKey* key, uint32_t, Formatting. http://codereview.chromium.org/9148006/diff/1011/src/objects.h#newcode2821 src/objects.h:2821: static inline uint32_t HashForObject(HashTableKey* key, uint32_t, Formatting. http://codereview.chromium.org/9148006/diff/1011/src/objects.h#newcode2972 src/objects.h:2972: static inline uint32_t Hash(String* key, uint32_t); Parameter should have a name. I'm unhappy that we need a seed here, when the hash is got from the string. http://codereview.chromium.org/9148006/diff/1011/src/objects.h#newcode2973 src/objects.h:2973: static inline uint32_t HashForObject(String* key, uint32_t, Formatting, and the parameter should have a name. http://codereview.chromium.org/9148006/diff/1011/src/objects.h#newcode3007 src/objects.h:3007: static inline uint32_t HashForObject(uint32_t key, uint32_t seed, Formatting. http://codereview.chromium.org/9148006/diff/1011/src/objects.h#newcode3067 src/objects.h:3067: static inline uint32_t Hash(Object* key, uint32_t); Names for arguments x2 http://codereview.chromium.org/9148006/diff/1011/src/utils.h File src/utils.h (right): http://codereview.chromium.org/9148006/diff/1011/src/utils.h#newcode257 src/utils.h:257: inline uint32_t ComputeIntegerHash(uint32_t key, uint32_t seed = 0) { Why do we need this default argument? http://codereview.chromium.org/9148006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
