Thanks for doing the test.
http://codereview.chromium.org/9148006/diff/9008/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/9148006/diff/9008/src/arm/macro-assembler-arm.cc#newcode1420 src/arm/macro-assembler-arm.cc:1420: mov(scratch, Operand(scratch, LSR, kSmiTagSize)); Use SmiUntag(scratch) http://codereview.chromium.org/9148006/diff/9008/src/arm/macro-assembler-arm.cc#newcode1422 src/arm/macro-assembler-arm.cc:1422: // Xor original key with a seed seed -> seed. http://codereview.chromium.org/9148006/diff/9008/src/arm/macro-assembler-arm.cc#newcode1438 src/arm/macro-assembler-arm.cc:1438: mov(scratch, Operand(2057)); This should be done with shifts and adds. See the bleeding edge code, where I fixed this yesterday. http://codereview.chromium.org/9148006/diff/9008/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/9148006/diff/9008/src/ia32/macro-assembler-ia32.cc#newcode981 src/ia32/macro-assembler-ia32.cc:981: xor_(r0, scratch); You should move this xor up into the if above, because you can then do it with a single xor instead of a mov and an xor. http://codereview.chromium.org/9148006/diff/9008/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/9148006/diff/9008/src/objects-inl.h#newcode4539 src/objects-inl.h:4539: // This function is unreachable, since shape has UsesSeed=true flag Please add a period (.) at the end of all comments. http://codereview.chromium.org/9148006/diff/9008/src/objects-inl.h#newcode4555 src/objects-inl.h:4555: uint32_t NumberDictionaryShape::SeededHashForObject(uint32_t key, uint32_t seed, All arguments on one line or one per line vertically aligned. http://codereview.chromium.org/9148006/diff/9008/src/objects.h File src/objects.h (right): http://codereview.chromium.org/9148006/diff/9008/src/objects.h#newcode2597 src/objects.h:2597: // Won't be called if UsesSeed isn't overrided by child class overrided ->overridden http://codereview.chromium.org/9148006/diff/9008/src/objects.h#newcode2602 src/objects.h:2602: // Won't be called if UsesSeed isn't overrided by child class And here. http://codereview.chromium.org/9148006/diff/9008/src/objects.h#newcode2770 src/objects.h:2770: There's a blank line too many here. http://codereview.chromium.org/9148006/diff/9008/src/objects.h#newcode2786 src/objects.h:2786: There's a missing blank line here. http://codereview.chromium.org/9148006/diff/9008/src/objects.h#newcode3043 src/objects.h:3043: static inline uint32_t SeededHashForObject(uint32_t key, uint32_t seed, Formatting. http://codereview.chromium.org/9148006/diff/9008/src/utils.h File src/utils.h (right): http://codereview.chromium.org/9148006/diff/9008/src/utils.h#newcode257 src/utils.h:257: inline uint32_t ComputeIntegerHash(uint32_t key, uint32_t seed = 0) { No default arguments. http://codereview.chromium.org/9148006/diff/9008/test/cctest/test-hashing.cc File test/cctest/test-hashing.cc (right): http://codereview.chromium.org/9148006/diff/9008/test/cctest/test-hashing.cc#newcode237 test/cctest/test-hashing.cc:237: Missing blank line here. http://codereview.chromium.org/9148006/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
