http://codereview.chromium.org/9148006/diff/8001/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/9148006/diff/8001/src/ia32/macro-assembler-ia32.cc#newcode987
src/ia32/macro-assembler-ia32.cc:987: // First of all lets assign to r1
value of HashSeed
"First of all we assign the hash seed to r1."

http://codereview.chromium.org/9148006/diff/8001/src/ia32/macro-assembler-ia32.cc#newcode1007
src/ia32/macro-assembler-ia32.cc:1007: not_(r0);
The intention is that the original should be xored with the seed, but
here r0 is input unchanged into the algorithm.  In the next line half of
the seed is thrown away.

http://codereview.chromium.org/9148006/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to