On 2012/01/12 12:00:06, Yury Semikhatsky wrote:
Daniel, could you take a look?
http://codereview.chromium.org/9139018/diff/4001/src/api.cc
File src/api.cc (left):
http://codereview.chromium.org/9139018/diff/4001/src/api.cc#oldcode6032
src/api.cc:6032:
On 2012/01/12 10:37:27, Mikhail Naganov (Chromium) wrote:
> nit: please, leave 2 lines here, too
Done.
http://codereview.chromium.org/9139018/diff/4001/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/9139018/diff/4001/src/api.cc#newcode4050
src/api.cc:4050:
On 2012/01/12 10:37:27, Mikhail Naganov (Chromium) wrote:
> nit: 2 empty lines between function definitions.
Done.
Drive-by:
As far as I can tell, every external string is registered to the external
string
table (class ExternalStringTable) when it's created and removed from it when
it's finalized (Heap::UpdateNewSpaceReferencesInExternalStringTable).
Wouldn't
it be easier and more efficient to iterate over this table instead of
checking
every object?
http://codereview.chromium.org/9139018/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
