Unfortunately, the test included in patch breaks with GCC 4.7 with a "set but
not used" warning.

http://codereview.chromium.org/9139018/diff/14001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/9139018/diff/14001/test/cctest/test-api.cc#newcode13723
test/cctest/test-api.cc:13723: v8::Local<v8::String> string2 =
v8::String::NewExternal(resource2);
The assignment to string1 and string2 breaks the build with GCC 4.7 as
it rightly warns:

../test/cctest/test-api.cc: In function 'void
TestVisitExternalStrings()':
../test/cctest/test-api.cc:13721:25: error: variable 'string1' set but
not used [-Werror=unused-but-set-variable]
../test/cctest/test-api.cc:13723:25: error: variable 'string2' set but
not used [-Werror=unused-but-set-variable]

http://codereview.chromium.org/9139018/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to