http://codereview.chromium.org/9139018/diff/14001/test/cctest/test-api.cc File test/cctest/test-api.cc (right):
http://codereview.chromium.org/9139018/diff/14001/test/cctest/test-api.cc#newcode13723 test/cctest/test-api.cc:13723: v8::Local<v8::String> string2 = v8::String::NewExternal(resource2); On 2012/01/13 20:57:01, Tobias Burnus wrote:
The assignment to string1 and string2 breaks the build with GCC 4.7 as
it
rightly warns:
../test/cctest/test-api.cc: In function 'void
TestVisitExternalStrings()':
../test/cctest/test-api.cc:13721:25: error: variable 'string1' set but
not used
[-Werror=unused-but-set-variable] ../test/cctest/test-api.cc:13723:25: error: variable 'string2' set but
not used
[-Werror=unused-but-set-variable]
I can add an artificial usages of string1 and string2 but the failure sounds wrong since v8::Local protects the strings from being GC'ed. I don't see why I cannot have assigned but never used scoped_ptr as a method local variable. What is recommended way of dealing with such warnings in v8? Btw, is there a build bot using GCC4.7 where I could see the failure? http://codereview.chromium.org/9139018/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
