OK, LGTM.
https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h#newcode444 src/ast.h:444: virtual bool IsInlineable() const; I think this method is obsolete (and the check in hydrogen.cc is unnecessary), because the declaration's inline-ability is already recorded in the function containing it. Talk to jkummerow. https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h#newcode473 src/ast.h:473: class VariableDeclaration: public Declaration { It's a little weird that VariableDeclaration includes 'function' and 'const' as well as 'var' and 'let'. Does the (proposed) ES grammar have a name for those things? https://chromiumcodereview.appspot.com/9348057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
