IsInlineable() LGTM.
https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h File src/ast.h (right): https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h#newcode444 src/ast.h:444: virtual bool IsInlineable() const; On 2012/02/08 15:23:04, Kevin Millikin wrote:
I think this method is obsolete (and the check in hydrogen.cc is
unnecessary),
because the declaration's inline-ability is already recorded in the
function
containing it. Talk to jkummerow.
This is true for all AstNodes *except* Declarations, because inline-ability of declarations is not known yet when the AstNodeFactory creates them. https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h#newcode450 src/ast.h:450: template<class> friend class AstNodeFactory; I think you don't need this any more. https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h#newcode475 src/ast.h:475: VariableDeclaration(VariableProxy* proxy, Suggestion: Move the constructor to a "protected:" section and add a "template<class> friend class AstNodeFactory;" in that section too, then the compiler will enforce for you that nobody accidentally calls the c'tor directly. https://chromiumcodereview.appspot.com/9348057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
