https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h File src/ast.h (right):
https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h#newcode450 src/ast.h:450: template<class> friend class AstNodeFactory; On 2012/02/08 15:40:28, Jakob wrote:
I think you don't need this any more.
Done. https://chromiumcodereview.appspot.com/9348057/diff/1/src/ast.h#newcode475 src/ast.h:475: VariableDeclaration(VariableProxy* proxy, On 2012/02/08 15:40:28, Jakob wrote:
Suggestion: Move the constructor to a "protected:" section and add a "template<class> friend class AstNodeFactory;" in that section too,
then the
compiler will enforce for you that nobody accidentally calls the c'tor
directly. Done. https://chromiumcodereview.appspot.com/9348057/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
