lgtm once you address comments.
https://chromiumcodereview.appspot.com/9401019/diff/5001/src/api.cc File src/api.cc (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/api.cc#newcode4027 src/api.cc:4027: add empty line https://chromiumcodereview.appspot.com/9401019/diff/5001/src/api.cc#newcode4032 src/api.cc:4032: add empty line https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc File src/frames.cc (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode45 src/frames.cc:45: ReturnAddressLocationResolver return_address_location_resolver = NULL; declare it static https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode49 src/frames.cc:49: Address* ResolveReturnAddressLocation(Address* pc_address) { declare it static https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode431 src/frames.cc:431: add empty line https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode434 src/frames.cc:434: return_address_location_resolver = resolver; assert that we don't have any other resolver installed. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/v8.cc File src/v8.cc (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/v8.cc#newcode147 src/v8.cc:147: +\n https://chromiumcodereview.appspot.com/9401019/diff/5001/src/v8.cc#newcode152 src/v8.cc:152: +\n https://chromiumcodereview.appspot.com/9401019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
