Thanks. How do I go about submitting this CL?
https://chromiumcodereview.appspot.com/9401019/diff/5001/src/api.cc File src/api.cc (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/api.cc#newcode4027 src/api.cc:4027: On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
add empty line
Done. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/api.cc#newcode4032 src/api.cc:4032: On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
add empty line
Done. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc File src/frames.cc (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode45 src/frames.cc:45: ReturnAddressLocationResolver return_address_location_resolver = NULL; On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
declare it static
Done. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode49 src/frames.cc:49: Address* ResolveReturnAddressLocation(Address* pc_address) { On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
declare it static
Done. Does this warrant "static inline" or are the compilers we use generally smart enough to work that out for themselves? https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode431 src/frames.cc:431: On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
add empty line
Done. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode434 src/frames.cc:434: return_address_location_resolver = resolver; On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
assert that we don't have any other resolver installed.
Done. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.h File src/frames.h (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.h#newcode245 src/frames.h:245: // to resolve the location of a return address to the location of the On 2012/02/24 10:35:59, Vyacheslav Egorov wrote:
trailing white space.
Ooops, done. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/v8.cc File src/v8.cc (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/v8.cc#newcode147 src/v8.cc:147: On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
+\n
Oops, force of habit. Done. https://chromiumcodereview.appspot.com/9401019/diff/5001/src/v8.cc#newcode152 src/v8.cc:152: On 2012/02/24 10:34:02, Vyacheslav Egorov wrote:
+\n
Done. https://chromiumcodereview.appspot.com/9401019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
