I will commit it for you. CQ does not work for V8.
https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc File src/frames.cc (right): https://chromiumcodereview.appspot.com/9401019/diff/5001/src/frames.cc#newcode49 src/frames.cc:49: Address* ResolveReturnAddressLocation(Address* pc_address) { On 2012/02/24 14:46:04, Ruðrugis wrote:
On 2012/02/24 10:34:02, Vyacheslav Egorov wrote: > declare it static
Done. Does this warrant "static inline" or are the compilers we use
generally smart
enough to work that out for themselves?
Yes, I think there is no harm declaring it inline (though these days it serves more as a way to communicate our "hope of inlining" to other code readers than to compiler). https://chromiumcodereview.appspot.com/9401019/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
