We are trying on an old windows machine we have here. I'll update you asap.
On Tue, Apr 24, 2012 at 11:38 AM, Florian Schneider <[email protected] > wrote: > Maybe - at the moment I don't have a Windows machine set up to test it. > @danno: Maybe someone else with a Windows setup can try this quickly? > > Den 24. apr. 2012 10.43 skrev Alexandre Rames <[email protected]>: > > It seems >> #include <intrin.h> >> directive is missing. >> >> msdn example use of __popcnt includes it. >> http://msdn.microsoft.com/en-us/library/bb385231.aspx >> >> It also includes it for _BitScanReverse and _BitScanForward >> http://msdn.microsoft.com/en-us/library/fbxyd7zd(v=vs.80).aspx >> But it seemed to work fine without it so I am not sure. >> >> >> On Mon, Apr 23, 2012 at 7:14 PM, Florian Schneider < >> [email protected]> wrote: >> >>> Unfortunately I had to revert the change because of Win32 compilation >>> errors: >>> >>> >>> http://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/3514/steps/compile/logs/stdio >>> >>> >>> >>> Den 23. apr. 2012 19.29 skrev <[email protected]>: >>> >>> LGTM. >>>> >>>> We'll land it. >>>> >>>> http://codereview.chromium.**org/9638018/<http://codereview.chromium.org/9638018/> >>>> >>> >>> >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
