Ok that works on our machine (with correct VS2008's _MSC_VER 1500). The patch should come soon.
On Tue, Apr 24, 2012 at 2:10 PM, Florian Schneider <[email protected]>wrote: > Thanks! That sounds good to me. > > Den 24. apr. 2012 15.00 skrev Alexandre Rames <[email protected]>: > > __popcnt was introduced with VS2008. >> Our VS2005 failed to compile for the same reason. >> >> We acan test MSC_VER and use a manual CountSetBits for versions prior to >> 2008: >> >> For MSVC++ 8.0 , _MSC_VER = 1400 >> >> So we can do >> #if _MSV_VER >= 1400 >> // Use __popcnt >> #else >> // Use hand coded CountSetBits. >> #endif >> >> I'll test this solution and upload it if it works. >> >> Alexandre >> >> >> >> >> On Tue, Apr 24, 2012 at 11:43 AM, Alexandre Rames < >> [email protected]> wrote: >> > >> > We are trying on an old windows machine we have here. I'll update you >> asap. >> > >> > >> > On Tue, Apr 24, 2012 at 11:38 AM, Florian Schneider < >> [email protected]> wrote: >> >> >> >> Maybe - at the moment I don't have a Windows machine set up to test >> it. @danno: Maybe someone else with a Windows setup can try this quickly? >> >> >> >> Den 24. apr. 2012 10.43 skrev Alexandre Rames < >> [email protected]>: >> >> >> >>> It seems >> >>> #include <intrin.h> >> >>> directive is missing. >> >>> >> >>> msdn example use of __popcnt includes it. >> >>> http://msdn.microsoft.com/en-us/library/bb385231.aspx >> >>> >> >>> It also includes it for _BitScanReverse and _BitScanForward >> >>> http://msdn.microsoft.com/en-us/library/fbxyd7zd(v=vs.80).aspx >> >>> But it seemed to work fine without it so I am not sure. >> >>> >> >>> >> >>> On Mon, Apr 23, 2012 at 7:14 PM, Florian Schneider < >> [email protected]> wrote: >> >>>> >> >>>> Unfortunately I had to revert the change because of Win32 >> compilation errors: >> >>>> >> >>>> >> http://build.chromium.org/p/client.v8/builders/V8%20Win32/builds/3514/steps/compile/logs/stdio >> >>>> >> >>>> >> >>>> >> >>>> Den 23. apr. 2012 19.29 skrev <[email protected]>: >> >>>> >> >>>>> LGTM. >> >>>>> >> >>>>> We'll land it. >> >>>>> >> >>>>> http://codereview.chromium.org/9638018/ >> >>>> >> >>>> >> >>> >> >> >> > >> > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
