Ported to changes to arm.
http://codereview.chromium.org/10443114/diff/11001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/10443114/diff/11001/src/hydrogen.cc#newcode699 src/hydrogen.cc:699: LChunkBuilder builder(info, this, &allocator, info->isolate()->zone()); On 2012/06/01 15:25:34, danno wrote:
Please put the zone in the graph. It's a simple change that I think
makes sense
even now.
Done. http://codereview.chromium.org/10443114/diff/11001/src/ia32/lithium-ia32.h File src/ia32/lithium-ia32.h (right): http://codereview.chromium.org/10443114/diff/11001/src/ia32/lithium-ia32.h#newcode2377 src/ia32/lithium-ia32.h:2377: zone_(zone), On 2012/06/01 15:25:34, danno wrote:
get it directly from the zone
Changed it to directly read the Zone off the HGraph. http://codereview.chromium.org/10443114/diff/11001/src/jsregexp.cc File src/jsregexp.cc (right): http://codereview.chromium.org/10443114/diff/11001/src/jsregexp.cc#newcode647 src/jsregexp.cc:647: zone); On 2012/06/01 15:25:34, danno wrote:
nit: weird indentation
Fixed. http://codereview.chromium.org/10443114/diff/11001/src/list.h File src/list.h (right): http://codereview.chromium.org/10443114/diff/11001/src/list.h#newcode48 src/list.h:48: // template <typename T, class P = FreeStoreAllocationPolicy> class List; On 2012/06/01 15:25:34, danno wrote:
May want to change the comment to use AllocationPolicy
Done. http://codereview.chromium.org/10443114/diff/11001/src/splay-tree.h File src/splay-tree.h (right): http://codereview.chromium.org/10443114/diff/11001/src/splay-tree.h#newcode190 src/splay-tree.h:190: explicit NodeDeleter() { On 2012/06/01 15:25:34, danno wrote:
Why is this change needed? I don't think you should add explicit here.
Removed it. http://codereview.chromium.org/10443114/diff/11001/src/v8globals.h File src/v8globals.h (right): http://codereview.chromium.org/10443114/diff/11001/src/v8globals.h#newcode159 src/v8globals.h:159: template <typename Config, class AllocationPolicy = FreeStoreAllocationPolicy> On 2012/06/01 15:25:34, danno wrote:
No need to change this file for just this one-line change.
Reverted the change. http://codereview.chromium.org/10443114/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
