LGTM with nits.
https://chromiumcodereview.appspot.com/10443114/diff/20003/src/hashmap.h File src/hashmap.h (right): https://chromiumcodereview.appspot.com/10443114/diff/20003/src/hashmap.h#newcode345 src/hashmap.h:345: : TemplateHashMapImpl<AllocationPolicy>( nit: two space indent from beginning of line here, and the following lines lined up accordingly. https://chromiumcodereview.appspot.com/10443114/diff/20003/src/zone.h File src/zone.h (right): https://chromiumcodereview.appspot.com/10443114/diff/20003/src/zone.h#newcode167 src/zone.h:167: // The ZoneAllocationPolicy is used to specialize the generic data nit: should be just "specialize generic data" https://chromiumcodereview.appspot.com/10443114/diff/20003/src/zone.h#newcode202 src/zone.h:202: // We add some convenience wrappers where so that we can pass in a nit: should be just "wrappers so that" https://chromiumcodereview.appspot.com/10443114/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
