http://codereview.chromium.org/10443114/diff/10002/src/compiler.cc File src/compiler.cc (right):
http://codereview.chromium.org/10443114/diff/10002/src/compiler.cc#newcode307 src/compiler.cc:307: Handle<Code> optimized_code = graph->Compile(info, info->isolate()->zone()); On 2012/06/04 10:46:46, danno wrote:
either graph->zone() or put the zone into CompilationInfo.
Changed to graph->zone() http://codereview.chromium.org/10443114/diff/10002/src/deoptimizer.h File src/deoptimizer.h (right): http://codereview.chromium.org/10443114/diff/10002/src/deoptimizer.h#newcode609 src/deoptimizer.h:609: On 2012/06/04 10:46:46, danno wrote:
nit: no space here, stay consistent with surrounding formatting.
Removed space. http://codereview.chromium.org/10443114/diff/10002/src/hashmap.h File src/hashmap.h (right): http://codereview.chromium.org/10443114/diff/10002/src/hashmap.h#newcode45 src/hashmap.h:45: TemplateHashMapImpl(MatchFun match, uint32_t capacity = 8, On 2012/06/04 10:46:46, danno wrote:
Turn default value into a constant so that you can specify the default
constant
when explicitly calling with an allocation.
Done. http://codereview.chromium.org/10443114/diff/10002/src/hashmap.h#newcode339 src/hashmap.h:339: : TemplateHashMapImpl<AllocationPolicy>(match, 8, allocator) { } On 2012/06/04 10:46:46, danno wrote:
As discussed above, use constant for this.
Done. http://codereview.chromium.org/10443114/diff/10002/src/parser.h File src/parser.h (right): http://codereview.chromium.org/10443114/diff/10002/src/parser.h#newcode838 src/parser.h:838: On 2012/06/04 10:46:46, danno wrote:
No extra space here to match surrounding code.
Done. http://codereview.chromium.org/10443114/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
