First round.
https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.cc#newcode1715 src/hydrogen-instructions.cc:1715: if (IsFastHoleyElementsKind(elements_kind())) { It seems as if we don't need the hole_check_mode flag for this instruction anymore, because it solely depends on the elements kind. Can we get rid of the flag, move the IsFastHoleyElementsKind() into a HLoadKeyedFastElements::MightHaveHoles() helper method and use this helper method here? https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.cc#newcode1722 src/hydrogen-instructions.cc:1722: if (IsFastPackedElementsKind(elements_kind())) { Likewise. https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.h#newcode622 src/hydrogen-instructions.h:622: virtual bool IsValueTaggedSmi() const { return false; } Can't we use HValue::CalculateInferredType instead of this new method? https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.h#newcode1853 src/hydrogen-instructions.h:1853: bool result_is_smi) Can we use an enum instead of a bool flag here? https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.h#newcode1875 src/hydrogen-instructions.h:1875: virtual bool IsValueTaggedSmi() const { See first comment in this file. https://chromiumcodereview.appspot.com/10543094/diff/6001/test/mjsunit/fast-array-length.js File test/mjsunit/fast-array-length.js (right): https://chromiumcodereview.appspot.com/10543094/diff/6001/test/mjsunit/fast-array-length.js#newcode28 test/mjsunit/fast-array-length.js:28: // Flags: --allow-natives-syntax --expose-gc It seems you don't need --expose-gc here. https://chromiumcodereview.appspot.com/10543094/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
