https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right):
https://chromiumcodereview.appspot.com/10543094/diff/6001/src/hydrogen-instructions.h#newcode622 src/hydrogen-instructions.h:622: virtual bool IsValueTaggedSmi() const { return false; } Yes, I agree, the representation has to be tagged. But on top of the representation we can calculate the inferred type of the value (that is represented as a tagged value). And I think that HType::Smi() actually indicates a tagged Smi value. We use the same for HStringLength as well, it has a tagged representation, but a Smi inferred type. On 2012/06/12 09:59:22, danno wrote:
No, unfortunately not. The representation is tagged, not integer. What
this
method indicates additionally that it is always a SMI, and that can't
be
expressed with the representation.
On 2012/06/12 08:10:43, Michael Starzinger wrote: > Can't we use HValue::CalculateInferredType instead of this new
method? https://chromiumcodereview.appspot.com/10543094/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
