LGTM (with one final nit).
https://chromiumcodereview.appspot.com/10543094/diff/7004/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://chromiumcodereview.appspot.com/10543094/diff/7004/src/hydrogen-instructions.cc#newcode1715 src/hydrogen-instructions.cc:1715: if (IsFastHoleyElementsKind(elements_kind())) { We could base the output of "check_hole" on the result of RequiresHoleCheck() below, to get accurate debug output. Not sure if that helps though. https://chromiumcodereview.appspot.com/10543094/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
