Thanks! LGTM, with some nits.
https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js File test/mjsunit/external-array.js (right): https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js#newcode479 test/mjsunit/external-array.js:479: assertEquals(ArrayBuffer, a.buffer.constructor); You can use the assertInstance helper that is defined at the beginning of the file (same below). Also, could you add the test to the other two cases above as well? https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js#newcode545 test/mjsunit/external-array.js:545: print(b.constructor) This probably fits better with the tests following line 145. https://chromiumcodereview.appspot.com/10697033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
