https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js File test/mjsunit/external-array.js (right):
https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js#newcode479 test/mjsunit/external-array.js:479: assertEquals(ArrayBuffer, a.buffer.constructor); On 2012/06/29 11:29:44, rossberg wrote:
You can use the assertInstance helper that is defined at the beginning
of the
file (same below). Also, could you add the test to the other two cases
above as
well?
Done. https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js#newcode545 test/mjsunit/external-array.js:545: print(b.constructor) On 2012/06/29 14:14:50, rossberg wrote:
On 2012/06/29 11:29:44, rossberg wrote: > This probably fits better with the tests following line 145.
Please don't just delete this test, but have it integrated with the
tests at
l.145 above. (It tests a different constructor call than the other
tests you
inserted.)
Done. https://chromiumcodereview.appspot.com/10697033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
