LGTM, with another comment.
https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js File test/mjsunit/external-array.js (right): https://chromiumcodereview.appspot.com/10697033/diff/1/test/mjsunit/external-array.js#newcode545 test/mjsunit/external-array.js:545: print(b.constructor) On 2012/06/29 11:29:44, rossberg wrote:
This probably fits better with the tests following line 145.
Please don't just delete this test, but have it integrated with the tests at l.145 above. (It tests a different constructor call than the other tests you inserted.) https://chromiumcodereview.appspot.com/10697033/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
