I am a little concerned that you might have subtly changed handlings of bailouts/failures/inlining. Have you run all of the benchmarks to make sure there are no regressions?
http://codereview.chromium.org/10700188/diff/10001/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/10700188/diff/10001/src/compiler.cc#newcode245 src/compiler.cc:245: return AbortOptimization(); Is this really equivalent to what was here before? Before, disableoptimization was always called. now you only call it in the non-inline case. Is the semantic the same? http://codereview.chromium.org/10700188/diff/10001/src/compiler.cc#newcode261 src/compiler.cc:261: return AbortOptimization(); Ditto. http://codereview.chromium.org/10700188/diff/10001/src/compiler.h File src/compiler.h (right): http://codereview.chromium.org/10700188/diff/10001/src/compiler.h#newcode343 src/compiler.h:343: Status CreateGraph(); MUST_USE_RESULT for this and the next two? http://codereview.chromium.org/10700188/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
