LGTM with comments
http://codereview.chromium.org/10700188/diff/11005/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/10700188/diff/11005/src/compiler.cc#newcode208 src/compiler.cc:208: return status != OptimizingCompiler::FAILED; nit: don't return here, or return after every if/else. Probably better: OptimizingCompiler::Status status = compiler.CreateGraph(); if (status != OptimizingCompiler::SUCCEEDED) { return status != OptimizingCompiler::FAILED; } status = nextStep..... OptimizingCompiler::Status status = compiler.CreateGraph(); if (status != OptimizingCompiler::SUCCEEDED) { return status != OptimizingCompiler::FAILED; } status = nextSTep.... OptimizingCompiler::Status status = compiler.CreateGraph(); return status != OptimizingCompiler::FAILED; http://codereview.chromium.org/10700188/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
