http://codereview.chromium.org/10700188/diff/10001/src/compiler.cc
File src/compiler.cc (right):

http://codereview.chromium.org/10700188/diff/10001/src/compiler.cc#newcode245
src/compiler.cc:245: return AbortOptimization();
On 2012/07/16 15:05:02, danno wrote:
Is this really equivalent to what was here before? Before,
disableoptimization
was always called. now you only call it in the non-inline case. Is the
semantic
the same?

Modified this part to make the logic clearer.

http://codereview.chromium.org/10700188/diff/10001/src/compiler.cc#newcode261
src/compiler.cc:261: return AbortOptimization();
On 2012/07/16 15:05:02, danno wrote:
Ditto.

Ditto.

http://codereview.chromium.org/10700188/diff/10001/src/compiler.h
File src/compiler.h (right):

http://codereview.chromium.org/10700188/diff/10001/src/compiler.h#newcode343
src/compiler.h:343: Status CreateGraph();
On 2012/07/16 15:05:02, danno wrote:
MUST_USE_RESULT for this and the next two?

Done.

http://codereview.chromium.org/10700188/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to