Addressed comments, PTAL.
https://chromiumcodereview.appspot.com/10816005/diff/9055/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://chromiumcodereview.appspot.com/10816005/diff/9055/src/arm/macro-assembler-arm.cc#newcode3704
src/arm/macro-assembler-arm.cc:3704: Register
empty_descriptor_array_value = r7;
On 2012/08/06 14:15:52, Michael Starzinger wrote:
Drop the "empty_descriptor_array_value".
Done.
https://chromiumcodereview.appspot.com/10816005/diff/9055/src/arm/macro-assembler-arm.cc#newcode3726
src/arm/macro-assembler-arm.cc:3726:
LoadRoot(empty_descriptor_array_value,
On 2012/08/06 14:15:52, Michael Starzinger wrote:
Better use r7 directly here, so that it's clear that CheckMap above
will destroy
it.
Done.
https://chromiumcodereview.appspot.com/10816005/diff/9055/src/factory.cc
File src/factory.cc (right):
https://chromiumcodereview.appspot.com/10816005/diff/9055/src/factory.cc#newcode123
src/factory.cc:123: void Factory::SetDescriptors(Handle<Map> map,
On 2012/08/06 14:15:52, Michael Starzinger wrote:
This method should definitely be moved into the "Map" class and be
made static.
Done.
https://chromiumcodereview.appspot.com/10816005/diff/9055/src/objects.cc
File src/objects.cc (right):
https://chromiumcodereview.appspot.com/10816005/diff/9055/src/objects.cc#newcode5253
src/objects.cc:5253: if (!(*HeapObject::RawField(transition_array,
On 2012/08/06 14:15:52, Michael Starzinger wrote:
The HeapObject::map() method should still work here. Also can we turn
this into
one single condition ...
if (!transition_array->map()->IsSmi() &&
!transition_array->IsTransitionArray()) {
return NULL;
}
Done.
https://chromiumcodereview.appspot.com/10816005/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
