PTAL.
https://chromiumcodereview.appspot.com/10816005/diff/22001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://chromiumcodereview.appspot.com/10816005/diff/22001/src/bootstrapper.cc#newcode544 src/bootstrapper.cc:544: On 2012/08/07 13:55:04, Michael Starzinger wrote:
Drop the empty newline.
Done. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1853 src/mark-compact.cc:1853: // array as weak and also mark that array to prevent visiting it later. On 2012/08/07 13:55:04, Michael Starzinger wrote:
These comments are completely outdated.
// Make sure that the back pointer stored either in the map itself or
inside
// its transitions array is marked. Treat pointers in the transitions
array
// as weak and also mark that array to prevent visiting it later.
Done. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1857 src/mark-compact.cc:1857: HeapObject::RawField(map, Map::kPointerFieldsBeginOffset); On 2012/08/07 13:55:04, Michael Starzinger wrote:
Move this down to the main marking loop again.
Done. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1863 src/mark-compact.cc:1863: mark_compact_collector()->RecordSlot( On 2012/08/07 13:55:05, Michael Starzinger wrote:
This slot is actually recorded in the main marking loop below. We can
drop it. Done. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1873 src/mark-compact.cc:1873: // to it. But make sure to skip back pointer. On 2012/08/07 13:55:05, Michael Starzinger wrote:
These comments are completely outdated.
// Mark the Object* fields of the Map. Since the transitions array has
been
// marked already, it is fine that one of these fields contains a
pointer
// to it.
Done. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1875 src/mark-compact.cc:1875: Map::kBitField3Offset + kPointerSize); On 2012/08/07 13:55:05, Michael Starzinger wrote:
This assert is no longer necessary, because we no longer shared
bit_field3 and
the backpointer.
Done. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1876 src/mark-compact.cc:1876: Object** end_slot = HeapObject::RawField(map, Map::kBitField3Offset); On 2012/08/07 13:55:05, Michael Starzinger wrote:
We can use Map::kPointerFieldsEndOffset here.
Done. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10816005/diff/22001/src/objects.h#newcode5039 src/objects.h:5039: // Storage for instance descriptors is overloaded to also contain additional On 2012/08/07 13:55:05, Michael Starzinger wrote:
These comments are completely outdated.
Done. https://chromiumcodereview.appspot.com/10816005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
