Second round.
https://chromiumcodereview.appspot.com/10816005/diff/22001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://chromiumcodereview.appspot.com/10816005/diff/22001/src/bootstrapper.cc#newcode402 src/bootstrapper.cc:402: Drop the empty newline. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/bootstrapper.cc#newcode544 src/bootstrapper.cc:544: Drop the empty newline. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1853 src/mark-compact.cc:1853: // array as weak and also mark that array to prevent visiting it later. These comments are completely outdated. // Make sure that the back pointer stored either in the map itself or inside // its transitions array is marked. Treat pointers in the transitions array // as weak and also mark that array to prevent visiting it later. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1857 src/mark-compact.cc:1857: HeapObject::RawField(map, Map::kPointerFieldsBeginOffset); Move this down to the main marking loop again. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1863 src/mark-compact.cc:1863: mark_compact_collector()->RecordSlot( This slot is actually recorded in the main marking loop below. We can drop it. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1873 src/mark-compact.cc:1873: // to it. But make sure to skip back pointer. These comments are completely outdated. // Mark the Object* fields of the Map. Since the transitions array has been // marked already, it is fine that one of these fields contains a pointer // to it. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1875 src/mark-compact.cc:1875: Map::kBitField3Offset + kPointerSize); This assert is no longer necessary, because we no longer shared bit_field3 and the backpointer. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/mark-compact.cc#newcode1876 src/mark-compact.cc:1876: Object** end_slot = HeapObject::RawField(map, Map::kBitField3Offset); We can use Map::kPointerFieldsEndOffset here. https://chromiumcodereview.appspot.com/10816005/diff/22001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10816005/diff/22001/src/objects.h#newcode5039 src/objects.h:5039: // Storage for instance descriptors is overloaded to also contain additional These comments are completely outdated. https://chromiumcodereview.appspot.com/10816005/diff/22001/test/cctest/test-alloc.cc File test/cctest/test-alloc.cc (right): https://chromiumcodereview.appspot.com/10816005/diff/22001/test/cctest/test-alloc.cc#newcode161 test/cctest/test-alloc.cc:161: v8::internal::Map::SetDescriptors(map, new_descriptors); We can drop the "v8::internal::" prefix for both of these lines, that's already the current namespace. https://chromiumcodereview.appspot.com/10816005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
