http://codereview.chromium.org/11037023/diff/25001/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/11037023/diff/25001/src/arm/assembler-arm.cc#newcode819 src/arm/assembler-arm.cc:819: return true; Indentation is off. http://codereview.chromium.org/11037023/diff/25001/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): http://codereview.chromium.org/11037023/diff/25001/src/arm/assembler-arm.h#newcode696 src/arm/assembler-arm.h:696: INLINE(static Address target_address_from_return_address(Address pc)); Can we have a one-liner comment of what this method does (also on other architectures). http://codereview.chromium.org/11037023/diff/25001/src/arm/assembler-arm.h#newcode1491 src/arm/assembler-arm.h:1491: class ScopedPredictableCodeSize { I would call this PredictableCodeSizeScope instead. http://codereview.chromium.org/11037023/diff/25001/src/assembler.h File src/assembler.h (right): http://codereview.chromium.org/11037023/diff/25001/src/assembler.h#newcode375 src/assembler.h:375: // location provides a place for these pointers to exist natually s/natually/naturally/ http://codereview.chromium.org/11037023/diff/25001/src/ia32/assembler-ia32.h File src/ia32/assembler-ia32.h (left): http://codereview.chromium.org/11037023/diff/25001/src/ia32/assembler-ia32.h#oldcode1 src/ia32/assembler-ia32.h:1: // Copyright (c) 1994-2006 Sun Microsystems Inc. Looks like a typo? http://codereview.chromium.org/11037023/diff/25001/src/ia32/assembler-ia32.h File src/ia32/assembler-ia32.h (right): http://codereview.chromium.org/11037023/diff/25001/src/ia32/assembler-ia32.h#newcode604 src/ia32/assembler-ia32.h:604: inline static Address target_address_from_return_address(Address pc); See comment in ARM assembler. http://codereview.chromium.org/11037023/diff/25001/src/x64/assembler-x64.h File src/x64/assembler-x64.h (right): http://codereview.chromium.org/11037023/diff/25001/src/x64/assembler-x64.h#newcode584 src/x64/assembler-x64.h:584: static inline Address target_address_from_return_address(Address pc); See comment in ARM assembler. http://codereview.chromium.org/11037023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
