Addressed comments, landing.
https://codereview.chromium.org/11037023/diff/39023/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right): https://codereview.chromium.org/11037023/diff/39023/src/arm/assembler-arm.cc#newcode843 src/arm/assembler-arm.cc:843: return true; It's not possible to use immediate loads to the pc to do a call, so loading the destination address without USE_BLX is always a single instruction of the form ldr pc, [pc + #xxx].On 2012/10/18 09:07:53, ulan wrote:
Why don't we check for !CpuFeatures::IsSupported(ARMv7) in this case?
https://codereview.chromium.org/11037023/diff/39023/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right): https://codereview.chromium.org/11037023/diff/39023/src/arm/assembler-arm.h#newcode757 src/arm/assembler-arm.h:757: static const int kPatchDebugBreakSlotReturnOffset = 2 * kInstrSize; On 2012/10/18 09:07:53, ulan wrote:
Is the offset correct when we don't use BLX?
Done. https://codereview.chromium.org/11037023/diff/39023/src/v8globals.h File src/v8globals.h (right): https://codereview.chromium.org/11037023/diff/39023/src/v8globals.h#newcode429 src/v8globals.h:429: UnknownImplementer, On 2012/10/18 09:07:53, ulan wrote:
Nit: names of constants are usually all upper case or prefixed with
'k'. Done. https://codereview.chromium.org/11037023/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
