First round of comments and nits.
https://codereview.chromium.org/11085070/diff/3001/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/11085070/diff/3001/src/flag-definitions.h#newcode572 src/flag-definitions.h:572: Also drop the empty line. https://codereview.chromium.org/11085070/diff/3001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/11085070/diff/3001/src/heap.cc#newcode468 src/heap.cc:468: allow_allocation(true); Neither the zapping nor the verification should do any allocation, so we can move this down right before the printing calls I think. https://codereview.chromium.org/11085070/diff/3001/src/heap.h File src/heap.h (right): https://codereview.chromium.org/11085070/diff/3001/src/heap.h#newcode1279 src/heap.h:1279: #endif Empty newline after the #endif https://codereview.chromium.org/11085070/diff/3001/src/objects-inl.h File src/objects-inl.h (right): https://codereview.chromium.org/11085070/diff/3001/src/objects-inl.h#newcode3647 src/objects-inl.h:3647: #ifndef DEBUG I think it would be useful to have a static inline function Heap::ShouldZapGarbage() that captures this predicate so to not spread it out across the entire code base. https://codereview.chromium.org/11085070/diff/3001/src/objects-inl.h#newcode3789 src/objects-inl.h:3789: #ifndef DEBUG Likewise. https://codereview.chromium.org/11085070/diff/3001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/11085070/diff/3001/src/objects.cc#newcode2188 src/objects.cc:2188: if (trim_mode != FROM_GC || zapInFromGCMode) { See comment about Heap::ShouldZapGarbage earlier. https://codereview.chromium.org/11085070/diff/3001/src/objects.cc#newcode9065 src/objects.cc:9065: Additional empty newline here. https://codereview.chromium.org/11085070/diff/3001/src/spaces.h File src/spaces.h (right): https://codereview.chromium.org/11085070/diff/3001/src/spaces.h#newcode2553 src/spaces.h:2553: virtual void Verify(); Empty newline after declaration. https://codereview.chromium.org/11085070/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
