addressed comments.
http://codereview.chromium.org/11085070/diff/17001/src/heap.cc
File src/heap.cc (right):
http://codereview.chromium.org/11085070/diff/17001/src/heap.cc#newcode382
src/heap.cc:382:
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Two empty newlines between function implementations.
Done.
http://codereview.chromium.org/11085070/diff/17001/src/heap.cc#newcode658
src/heap.cc:658:
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Two empty newlines between function implementations.
Done.
http://codereview.chromium.org/11085070/diff/17001/src/heap.cc#newcode4705
src/heap.cc:4705: ? new_space_.AllocateRaw(size)
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Indentation is off.
Done.
http://codereview.chromium.org/11085070/diff/17001/src/objects-inl.h
File src/objects-inl.h (right):
http://codereview.chromium.org/11085070/diff/17001/src/objects-inl.h#newcode3632
src/objects-inl.h:3632: if (Heap::ShouldZapGarbage()) {
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Let's also use the following here, it's equivalent and more concise:
if (Heap::ShouldZapGarbage() && HasTransitionArray()) {
ZapTransitions();
}
Done.
http://codereview.chromium.org/11085070/diff/17001/src/objects.h
File src/objects.h (right):
http://codereview.chromium.org/11085070/diff/17001/src/objects.h#newcode1250
src/objects.h:1250:
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Dropping these two newlines would be consistent with the rest of the
file.
Done.
http://codereview.chromium.org/11085070/diff/17001/src/objects.h#newcode8813
src/objects.h:8813: #undef DECL_ACCESSORS
On 2012/10/12 10:53:16, Michael Starzinger wrote:
We should also undef the DECLARE_VERIFIER macro here.
Done.
http://codereview.chromium.org/11085070/diff/17001/src/spaces.cc
File src/spaces.cc (right):
http://codereview.chromium.org/11085070/diff/17001/src/spaces.cc#newcode2558
src/spaces.cc:2558: // MVSTANTON: this is weird...the compiler can't
make a vtable unless there is
On 2012/10/12 10:53:16, Michael Starzinger wrote:
If you want to leave that comment in, format it like follows:
TODO(mvstanton): This is weird ...
Done.
http://codereview.chromium.org/11085070/diff/17001/src/spaces.cc#newcode2569
src/spaces.cc:2569: // MVSTANTON: same as above
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Likewise.
Done.
http://codereview.chromium.org/11085070/diff/17001/src/spaces.cc#newcode2788
src/spaces.cc:2788:
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Two empty newlines between function implementations.
Done.
http://codereview.chromium.org/11085070/diff/17001/src/spaces.cc#newcode2838
src/spaces.cc:2838:
On 2012/10/12 10:53:16, Michael Starzinger wrote:
Two empty newlines between function implementations.
Done.
http://codereview.chromium.org/11085070/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
